Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.12] gh-108303: Move all inspect test files to test_inspect/ (GH-109607) #110732

Merged
merged 2 commits into from
Oct 13, 2023
Merged

[3.12] gh-108303: Move all inspect test files to test_inspect/ (GH-109607) #110732

merged 2 commits into from
Oct 13, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 11, 2023 •
edited by bedevere-app bot
Loading

(cherry picked from commit 732532b)

@bedevere-app bedevere-app bot mentioned this pull request Oct 11, 2023
Merged
@bedevere-app bedevere-app bot mentioned this pull request Oct 11, 2023
Closed
@sobolevn
Copy link
Member Author

@vstinner we need this PR to get backported: #109403

Otherwise, tests won't pass due to a findtests bug :(

@vstinner
Copy link
Member

@vstinner we need this PR to get backported: #109403

It became impossible to backport a single regrtest change, the 3.12 and main branches became too different. So I wrote PR #110758 to copy regrtest files from main to 3.12 branch.

@sobolevn sobolevn closed this Oct 13, 2023
@sobolevn sobolevn reopened this Oct 13, 2023
@vstinner
Copy link
Member

Can you please rebase your PR on the 3.12 branch to solve the libregrtest merge conflict?

@sobolevn
Copy link
Member Author

Should be good now! Thanks a lot for your backport PRs! They are really helpful.

@vstinner vstinner merged commit 0102faf into python:3.12 Oct 13, 2023
22 checks passed
@vstinner vstinner added the needs backport to 3.11 only security fixes label Oct 13, 2023
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @sobolevn and @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0102faf0cac107fd4d0fde9902560c7cf0a3be9d 3.11

@vstinner
Copy link
Member

I was feeling lucky and tried automated backport...

@sobolevn: Do you want to try to backport to 3.11? Otherwise, I can try to backport.

@sobolevn
Copy link
Member Author

Will do tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner Awaiting requested review from vstinner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@encukou encukou Awaiting requested review from encukou encukou is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

@vstinner vstinner

Labels
needs backport to 3.11 only security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @vstinner @miss-islington